Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bail fast if function returns error #4016

Merged
merged 1 commit into from
Jun 16, 2023
Merged

Bail fast if function returns error #4016

merged 1 commit into from
Jun 16, 2023

Conversation

jjngx
Copy link
Contributor

@jjngx jjngx commented Jun 16, 2023 •
edited
Loading

Proposed changes

This PR introduces following update to test assertions:

  • if tested function/method returns an error the test fails immediately
  • remove an attempt to compare unknown output from failing function/method

Checklist

  • I have read the CONTRIBUTING doc
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked that all unit tests pass after adding my changes
  • I have updated necessary documentation
  • I have rebased my branch onto main
  • I will ensure my PR is targeting the main branch and pulling from my branch from my own fork

@jjngx jjngx requested a review from a team as a code owner June 16, 2023 10:53
@github-actions github-actions bot added the tests Pull requests that update tests label Jun 16, 2023
@github-actions
Copy link

Dependency Review

✅ No vulnerabilities or license issues found.

Scanned Manifest Files

@jjngx jjngx changed the title Bail fast if func returns err Bail fast if function returns error Jun 16, 2023
@jjngx jjngx requested review from haywoodsh, shaun-nx and vepatel June 16, 2023 10:54
@codecov
Copy link

codecov bot commented Jun 16, 2023

Codecov Report

Merging #4016 (7131db5) into main (6494ab5) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main    #4016   +/-   ##
=======================================
  Coverage   51.81%   51.81%           
=======================================
  Files          59       59           
  Lines       16697    16697           
=======================================
  Hits         8651     8651           
  Misses       7747     7747           
  Partials      299      299

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@jjngx jjngx merged commit 763ad99 into main Jun 16, 2023
@jjngx jjngx deleted the tests/extended-monitoring branch June 16, 2023 12:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vepatel vepatel vepatel approved these changes

@haywoodsh haywoodsh haywoodsh approved these changes

@shaun-nx shaun-nx Awaiting requested review from shaun-nx

Assignees
No one assigned
Labels
tests Pull requests that update tests
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jjngx @haywoodsh @vepatel